Skip to content

[yaml] : add bigquery write with dynamic destination example#37594

Merged
claudevdm merged 1 commit intoapache:masterfrom
derrickaw:20260213_createYamlDynamicDestinationExample
Feb 26, 2026
Merged

[yaml] : add bigquery write with dynamic destination example#37594
claudevdm merged 1 commit intoapache:masterfrom
derrickaw:20260213_createYamlDynamicDestinationExample

Conversation

@derrickaw
Copy link
Collaborator

@derrickaw derrickaw commented Feb 13, 2026 •
edited
Loading

  1. Provide another dynamic destination example for yaml, but with bigquery this time.
  2. beam/sdks/python/apache_beam/yaml$ pytest -v examples/testing/examples_test.py::IOTest
  3. python -m apache_beam.yaml.main --yaml_pipeline_file=apache_beam/yaml/examples/transforms/io/bigquery_write.yaml --project=<project_id> --temp_location=gs://<my_bucket>/temp

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 13, 2026

Summary of Changes

Hello @derrickaw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Apache Beam Python SDK by introducing a new YAML-based example that illustrates writing data to Google BigQuery with dynamic destinations. This addition provides a practical, declarative demonstration of a common data processing pattern, expanding the utility of YAML pipelines for BigQuery users.

Highlights

  • New BigQuery YAML Example: Added a new YAML example demonstrating how to write data to BigQuery using dynamic destinations, allowing data to be routed to different tables based on a field's value.
  • Test Suite Integration: Integrated the new BigQuery YAML example into the existing Python YAML examples test suite to ensure its functionality and correctness.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sdks/python/apache_beam/yaml/examples/testing/examples_test.py
    • Added 'test_bigquery_write_yaml' to the list of YAML examples to be tested by the _io_write_test_preprocessor.
  • sdks/python/apache_beam/yaml/examples/transforms/io/bigquery_write.yaml
    • Created a new YAML file defining a Beam pipeline that generates sample data and writes it to BigQuery tables dynamically based on the 'country' field, utilizing WriteToBigQuery with dynamic destinations.
Activity
  • No specific activity (comments, reviews, or progress updates) was provided in the context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@derrickaw
Copy link
Collaborator Author

derrickaw commented Feb 13, 2026

Run Python_Dataframes PreCommit 3.12

@derrickaw derrickaw marked this pull request as ready for review February 13, 2026 18:16
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2026

Assigning reviewers:

R: @claudevdm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2026

Reminder, please take a look at this pr: @claudevdm

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@claudevdm
Copy link
Collaborator

claudevdm commented Feb 25, 2026

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 25, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new YAML example for writing to BigQuery using dynamic destinations. The associated test file is correctly updated to mock the I/O write for this new example. However, the new YAML file itself contains an invalid configuration parameter, num_streams, for the WriteToBigQuery transform. This would cause the example to fail at runtime. My review includes a critical comment to remove this invalid parameter.

@derrickaw derrickaw force-pushed the 20260213_createYamlDynamicDestinationExample branch from b24fdea to b1e4402 Compare February 25, 2026 19:33
@derrickaw derrickaw force-pushed the 20260213_createYamlDynamicDestinationExample branch from b1e4402 to eb169f0 Compare February 26, 2026 13:05
@derrickaw
Copy link
Collaborator Author

derrickaw commented Feb 26, 2026 •
edited
Loading

These failures don't seem related to this PR.

@claudevdm claudevdm merged commit 9eb3a18 into apache:master Feb 26, 2026
89 of 97 checks passed
@derrickaw derrickaw deleted the 20260213_createYamlDynamicDestinationExample branch February 26, 2026 15:35
@Abacn
Copy link
Contributor

Abacn commented Feb 26, 2026

These failures don't seem related to this PR.

Can you confirm the added example is exercised in one of the passing tests?

https://github.com/apache/beam/actions/workflows/beam_PreCommit_Yaml_Xlang_Direct.yml has been broken for a while. I doubt the PR merged without test coverage.

We keep see Python tests breakage recently. Please merge after test signal stablized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claudevdm claudevdm claudevdm approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Next Action: Reviewers python reassigned-reviewers yaml

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@derrickaw @claudevdm @Abacn